Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pagination for channels cli and reorg the query_txs() #827

Merged
merged 9 commits into from
Apr 16, 2021
Merged

Fix pagination for channels cli and reorg the query_txs() #827

merged 9 commits into from
Apr 16, 2021

Conversation

ancazamfir
Copy link
Collaborator

Closes: #811

Description

  • fixed pagination for hermes query channels
  • clarify that query_txs() only queries one tx at a time, reorg the code a bit. added comments

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@ancazamfir ancazamfir requested a review from romac as a code owner April 15, 2021 13:43
romac
romac requested changes Apr 15, 2021
View reviewed changes
relayer/src/chain/cosmos.rs Outdated Show resolved Hide resolved
relayer/src/chain/cosmos.rs Outdated Show resolved Hide resolved
relayer/src/chain/cosmos.rs Outdated Show resolved Hide resolved
@codecov-io

This comment has been minimized.

Sign in to view
romac
romac requested changes Apr 15, 2021
View reviewed changes
relayer/src/chain/cosmos.rs Show resolved Hide resolved
@ancazamfir ancazamfir requested a review from romac April 16, 2021 07:56
@romac romac merged commit 6543083 into master Apr 16, 2021
@romac romac deleted the anca/grpc_pag branch April 16, 2021 14:16
@ancazamfir ancazamfir mentioned this pull request Apr 26, 2021
Closed
5 tasks
@romac romac mentioned this pull request May 3, 2021
Closed
5 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@ancazamfir @romac
Fix pagination for channels cli and reorg the query_txs() (informalsy…
b66d77e 
…stems#827)

* Fix pagination for channels cli and reorg the query_txs()

* Update changelog

* Cleanup comments

* Refactor update_client_from_tx_search_response to use iterators

* Address own review comments

* Refactor packet_from_tx_search_response

* Small stylistic change

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some (g)RPC queries are missing proper pagination
3 participants
@ancazamfir @codecov-io @romac